Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server silently accepts ClientHello messages with invalid Extension lengths #265

Closed
jurajsomorovsky opened this issue Apr 23, 2015 · 1 comment

Comments

@jurajsomorovsky
Copy link

While playing with the OpenSSL server (version 1.0.2a), I found out it is possible to send ClientHello messages with invalid extension lengths where the extension length is larger than the amount of the extension data. If the server receives such a ClientHello message, it correctly omits further extension processing. However, it does not return any decoding error and proceeds with the handshake.

Even though this does not lead to any security vulnerability, I believe returning a decoding alert would be a correct practice (or is there any compatibility reason for not returning such an alert?)
I believe, this issue should be fixed here:
https://github.com/openssl/openssl/blob/master/ssl/t1_lib.c#L1941

@mattcaswell mattcaswell added this to the 1.0.2 milestone May 16, 2016
@mattcaswell
Copy link
Member

This was fixed a while ago in d272599. Closing.

mcr pushed a commit to mcr/openssl that referenced this issue Jun 22, 2021
…hip_tests

Silence warning on spaceship tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants