Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_min_proto_version() does not validate that min <= max #5127

Closed
tiran opened this issue Jan 21, 2018 · 1 comment
Closed

set_min_proto_version() does not validate that min <= max #5127

tiran opened this issue Jan 21, 2018 · 1 comment
Milestone
1.1.1

Comments

@tiran
Copy link
Contributor

tiran commented Jan 21, 2018

The setter combination SSL_CTX_set_min_proto_version() and SSL_CTX_set_max_proto_version() as well as SSL_set_min_proto_version() and SSL_set_max_proto_version() accept invalid combinations of min and max protocol. For example it is possible to set a minimum version of TLS 1.2 but a maximum version of TLS 1.0. The helper function ssl_check_allowed_versions should prevent min_version > max_version.
tiran added a commit to tiran/openssl that referenced this issue Jan 21, 2018
@tiran
Refuse min proto version > max proto version
3bc53c8 
SSL_CTX_set_min_proto_version() and SSL_CTX_set_max_proto_version() as
well as their SSL equivalents now validate that the mininum protocol
version is lower or requal the maximum protocol version.

Closes: openssl#5127
Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran mentioned this issue Jan 21, 2018
Closed
@mattcaswell mattcaswell added this to the 1.1.1 milestone Jan 22, 2018
@kaduk
Copy link
Contributor

kaduk commented Feb 28, 2018

Discussion on #5128 indicates that this is not an issue, or rather, that valid combinations of setting min and max proto versions may validly progress through a state with the configured min > the configured max, so we cannot safely assert that that relation holds when setting either the min or max version.
So, closing (but leaving the pull request open for the added tests).

@kaduk kaduk closed this as completed Feb 28, 2018
levitte pushed a commit to levitte/openssl that referenced this issue Jun 21, 2018
@tiran @levitte
Refuse min proto version > max proto version
76278d6 
SSL_CTX_set_min_proto_version() and SSL_CTX_set_max_proto_version() as
well as their SSL equivalents now validate that the mininum protocol
version is lower or requal the maximum protocol version.

Closes: openssl#5127
Signed-off-by: Christian Heimes <christian@python.org>
@levitte levitte mentioned this issue Jun 21, 2018
Closed
@kroeckx kroeckx mentioned this issue Nov 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Refuse min proto version > max proto version (cont.) levitte/openssl
3 participants
@tiran @kaduk @mattcaswell