Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make public SM2 functions libcrypto private #5670

Closed
levitte opened this issue Mar 19, 2018 · 7 comments
Closed

Make public SM2 functions libcrypto private #5670

levitte opened this issue Mar 19, 2018 · 7 comments
Labels
branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Milestone
1.1.1

Comments

@levitte
Copy link
Member

levitte commented Mar 19, 2018

#4793 added a few public SM2 function that really shouldn't be, They're only used by the EC code and the SM2 functionality should only be reachable through the EVP API.

As a consequence, the two test programs test/sm2crypttest.c and test/sm2sigtest.c should be viewed as internal and allowed to access those SM2 functions. SM2 through the EVP API is already tested with added data in test/recipes/30-test_evp_data/evppkey.txt
@levitte levitte added the branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch label Mar 19, 2018
@levitte levitte mentioned this issue Mar 19, 2018
Closed
2 tasks
@randombit
Copy link
Contributor

I can address this but probably will not have time to create a PR until Friday or Saturday.

@ronaldtse
Copy link
Contributor

Thanks @randombit , @levitte !

@mattcaswell mattcaswell added this to the 1.1.1 milestone Mar 20, 2018
@mattcaswell
Copy link
Member

Hi @randombit - any update on this?

@randombit
Copy link
Contributor

@mattcaswell Sorry for the holdup, should be able to look at this tomorrow

@randombit randombit mentioned this issue Apr 6, 2018
Closed
@randombit
Copy link
Contributor

@mattcaswell @levitte Fixed in PR #5895

randombit pushed a commit to randombit/openssl that referenced this issue May 16, 2018
Make SM2 functions private
ff06d0e 
Address issue openssl#5670
mattcaswell pushed a commit to mattcaswell/openssl that referenced this issue May 31, 2018
@mattcaswell
Make SM2 functions private
9e78b6d 
Address issue openssl#5670
levitte pushed a commit that referenced this issue Jun 4, 2018
@mattcaswell
Make SM2 functions private
e425f90 
Address issue #5670

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #6386)
@richsalz
Copy link
Contributor

Since #5895 was closed, closing this.
Thanks!

@ronaldtse
Copy link
Contributor

Thank you @levitte @randombit @mattcaswell @richsalz ! 👍

@qingfeng14 qingfeng14 mentioned this issue Sep 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
5 participants
@ronaldtse @randombit @levitte @richsalz @mattcaswell