Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE: Add a generic callback function type #10412

Closed
wants to merge 2 commits into from
Closed

CORE: Add a generic callback function type #10412

wants to merge 2 commits into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Nov 11, 2019

This offers a very generic way to define a callback as well as calling
it.

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Nov 11, 2019
@levitte levitte added this to the 3.0.0 milestone Nov 11, 2019
@levitte levitte added this to In progress in 3.0 New Core + FIPS via automation Nov 11, 2019
@levitte
Copy link
Member Author

levitte commented Nov 11, 2019

This is an alternative to #10390

@levitte
Copy link
Member Author

levitte commented Nov 11, 2019

So, I've made an alternative for #10391 that works with this PR (#10414). As for #10394 and #10289, I think I'll wait with the work on those until I have a yay or nay here (I sure hope I get a yay).

@levitte
Copy link
Member Author

levitte commented Nov 12, 2019

Ping.

@levitte levitte mentioned this pull request Nov 12, 2019
Closed
3.0 New Core + FIPS automation moved this from In progress to Reviewer approved Nov 12, 2019
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 12, 2019
This was referenced Nov 12, 2019
Closed
Closed
@levitte
CORE: Add a generic callback function type
063c53b 
This offers a very generic way to define a callback as well as calling
it.
@levitte
fixup! CORE: Add a generic callback function type
f24f280
@levitte levitte mentioned this pull request Nov 13, 2019
Merged
@levitte
Copy link
Member Author

levitte commented Nov 14, 2019

Merged.

10e7216 CORE: Add a generic callback function type

@levitte levitte closed this Nov 14, 2019
3.0 New Core + FIPS automation moved this from Reviewer approved to Done Nov 14, 2019
openssl-machine pushed a commit that referenced this pull request Nov 14, 2019
@levitte
CORE: Add a generic callback function type
10e7216 
This offers a very generic way to define a callback as well as calling
it.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #10412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
No open projects
3.0 New Core + FIPS
  
Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@levitte @mattcaswell