libcrypto.num: remove some unused EVP_MAC symbols #10421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspncp
added
approval: otc review pending
levitte
approved these changes
Nov 12, 2019
levitte
added
approval: done
|
Oh, BTW: are there any more ephemeral symbols in this list, which need to be removed too? ~/src/openssl$ grep -n '\?.*NOEXIST' util/libcrypto.num
4428:EVP_MAC_CTX_new_id ? 3_0_0 NOEXIST::FUNCTION:
4452:CRYPTO_siv128_new ? 3_0_0 NOEXIST::FUNCTION:SIV
4453:CRYPTO_siv128_init ? 3_0_0 NOEXIST::FUNCTION:SIV
4454:CRYPTO_siv128_copy_ctx ? 3_0_0 NOEXIST::FUNCTION:SIV
4455:CRYPTO_siv128_aad ? 3_0_0 NOEXIST::FUNCTION:SIV
4456:CRYPTO_siv128_encrypt ? 3_0_0 NOEXIST::FUNCTION:SIV
4457:CRYPTO_siv128_decrypt ? 3_0_0 NOEXIST::FUNCTION:SIV
4458:CRYPTO_siv128_finish ? 3_0_0 NOEXIST::FUNCTION:SIV
4459:CRYPTO_siv128_set_tag ? 3_0_0 NOEXIST::FUNCTION:SIV
4460:CRYPTO_siv128_get_tag ? 3_0_0 NOEXIST::FUNCTION:SIV
4461:CRYPTO_siv128_cleanup ? 3_0_0 NOEXIST::FUNCTION:SIV
4462:CRYPTO_siv128_speed ? 3_0_0 NOEXIST::FUNCTION:SIV
4660:EVP_PKEY_derive_init_ex ? 3_0_0 NOEXIST::FUNCTION:
4671:ERR_put_func_error ? 3_0_0 NOEXIST::FUNCTION:
4712:EVP_MAC_name ? 3_0_0 NOEXIST::FUNCTION:
4723:EVP_KDF_name ? 3_0_0 NOEXIST::FUNCTION:
4736:EVP_PKEY_sign_init_ex ? 3_0_0 NOEXIST::FUNCTION:
4738:EVP_PKEY_verify_init_ex ? 3_0_0 NOEXIST::FUNCTION:
4739:EVP_PKEY_verify_recover_init_ex ? 3_0_0 NOEXIST::FUNCTION: |
mspncp
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Nov 13, 2019
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #10421)
|
Merged to master in a7372f5, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.