Make ECDSA_size() use consistent asn1 encoder. #10577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slontis
commented
Dec 5, 2019
| if (group == NULL) | ||
| return 0; | ||
|
|
||
| i = EC_GROUP_order_bits(group); | ||
| if (i == 0) | ||
| bn = EC_GROUP_get0_order(group); |
There was a problem hiding this comment.
I was concerned there might be a off by 1 problem here if the order does not have the top bit set..
There are some curves that have 1FFFFF at the top but those ones should be ok..
There was a problem hiding this comment.
r & s are modulus of the order.. so should be less than this upper value
slontis
added
approval: otc review pending
|
(There's a typo "ECDA_size()" in the commit message) |
slontis
force-pushed
the
ECDSA_size_fix
branch
from
855de13
to
a3d100b
Compare
|
Updated the commit to remove the typo.. |
|
ping |
ECDSA signature lengths are calculated using i2d_ECDSA_SIG(). i2d_ECDSA_SIG() was changed in a previous PR to use a custom ASN1 encoder (using WPACKET) so that the normal ASN1 encoder does not need to be pulled into the provider boundary. For consistency ECDSA_size() has been changed to also use i2d_ECDSA_SIG() - this can now be used directly inside the FIPS provider.
slontis
force-pushed
the
ECDSA_size_fix
branch
from
a3d100b
to
1cfc318
Compare
|
rebased with no new changes to the code. |
romen
added
approval: done
slontis
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Jan 7, 2020
ECDSA signature lengths are calculated using i2d_ECDSA_SIG(). i2d_ECDSA_SIG() was changed in a previous PR to use a custom ASN1 encoder (using WPACKET) so that the normal ASN1 encoder does not need to be pulled into the provider boundary. For consistency ECDSA_size() has been changed to also use i2d_ECDSA_SIG() - this can now be used directly inside the FIPS provider. Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> (Merged from #10577)
|
Thanks romen. Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECDSA signature lengths are calculated using i2d_ECDSA_SIG().
i2d_ECDSA_SIG() was changed in a previous PR to use a custom ASN1 encoder (using WPACKET)
so that the normal ASN1 encoder does not need to be pulled into the provider boundary.
For consistency ECDSA_size() has been changed to also use i2d_ECDSA_SIG() - this can now
be used directly inside the FIPS provider.
Checklist