Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testutil_init.c: fix compilation error with enable-trace #10732

Closed
wants to merge 1 commit into from
Closed

testutil_init.c: fix compilation error with enable-trace #10732

wants to merge 1 commit into from

Conversation

mspncp
Copy link
Contributor

@mspncp mspncp commented Dec 31, 2019

In commit e79ae96 the tests were adapted to use the
new BIO_f_prefix() API which was introduced in 319cee9.
This location was missed, because it is compiled only when
tracing is enabled.

Fixes #10731

@mspncp
testutil_init.c: fix compilation error with enable-trace
b63bf77 
In commit e79ae96 the tests were adapted to use the
new BIO_f_prefix() API which was introduced in 319cee9.
This location was missed, because it is compiled only when
tracing is enabled.

Fixes openssl#10731
@mspncp mspncp requested a review from levitte December 31, 2019 11:31
@mspncp mspncp mentioned this pull request Dec 31, 2019
Closed
@mspncp mspncp added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Dec 31, 2019
@slontis slontis added this to In progress in 3.0 New Core + FIPS via automation Jan 7, 2020
3.0 New Core + FIPS automation moved this from In progress to Reviewer approved Jan 8, 2020
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 8, 2020
@slontis slontis added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 10, 2020
@slontis slontis self-assigned this Jan 10, 2020
openssl-machine pushed a commit that referenced this pull request Jan 10, 2020
@mspncp @slontis
testutil_init.c: fix compilation error with enable-trace
7671420 
In commit e79ae96 the tests were adapted to use the
new BIO_f_prefix() API which was introduced in 319cee9.
This location was missed, because it is compiled only when
tracing is enabled.

Fixes #10731

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #10732)
@slontis
Copy link
Member

slontis commented Jan 10, 2020

Thanks.. merged to master.

@slontis slontis closed this Jan 10, 2020
3.0 New Core + FIPS automation moved this from Reviewer approved to Done Jan 10, 2020
@mspncp mspncp deleted the pr-fix-prefix branch February 14, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@slontis slontis slontis approved these changes

Assignees

@slontis slontis

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
No open projects
3.0 New Core + FIPS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/testutil/testutil_init.c does not compile with enable-trace
3 participants
@mspncp @slontis @levitte