Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: The interpretation of OPENSSL_API_COMPAT has changed, update docs #10765

Closed
wants to merge 4 commits into from
Closed

DOCS: The interpretation of OPENSSL_API_COMPAT has changed, update docs #10765

wants to merge 4 commits into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Jan 6, 2020

Checklist
  • documentation is added or updated

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Jan 6, 2020
InfoHunter
InfoHunter reviewed Jan 7, 2020
View reviewed changes
doc/man7/openssl_user_macros.pod.in Outdated Show resolved Hide resolved
doc/man7/openssl_user_macros.pod.in Outdated Show resolved Hide resolved
@kaduk
Copy link
Contributor

kaduk commented Jan 7, 2020

Probably want to s/hass/has/ in the commit message...

@levitte levitte changed the title DOCS: The interpretation of OPENSSL_API_COMPAT hass changed, update docs DOCS: The interpretation of OPENSSL_API_COMPAT has changed, update docs Jan 7, 2020
InfoHunter
InfoHunter approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@InfoHunter InfoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Oxford comma is 'optional'. Approve if it's changed to Oxford comma or not :-)

@InfoHunter InfoHunter added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 8, 2020
mspncp
mspncp reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@mspncp mspncp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits.

doc/man7/openssl_user_macros.pod.in Outdated Show resolved Hide resolved
doc/man7/openssl_user_macros.pod.in Outdated Show resolved Hide resolved
InfoHunter
InfoHunter approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@InfoHunter InfoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve again

openssl-machine pushed a commit that referenced this pull request Jan 9, 2020
@levitte
DOCS: The interpretation of OPENSSL_API_COMPAT has changed, update docs
cc4ff10 
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
(Merged from #10765)
@levitte
Copy link
Member Author

levitte commented Jan 9, 2020

Merged.

cc4ff10 DOCS: The interpretation of OPENSSL_API_COMPAT has changed, update docs

@levitte levitte closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richsalz richsalz richsalz left review comments

@InfoHunter InfoHunter InfoHunter approved these changes

@mspncp mspncp mspncp approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@levitte @kaduk @InfoHunter @richsalz @mspncp