Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/openssl: make index.txt errors more verbose #10818

Closed
wants to merge 0 commits into from

Conversation

FlorianMickler
Copy link
Contributor

openssl ca was a little bit too silent, when it couldnt parse index.txt ...

steps to reproduce: create index.txt with

echo "" > index.txt

which creates

hexdump index.txt
0000000 000a
0000001

-> Trivial change, tested with openssl ca to sign a csr
-> the ocsp and svr changes were only compile tested by me, but seemed to make sense. ?

Checklist

@FlorianMickler
Copy link
Contributor Author

@FlorianMickler
Copy link
Contributor Author

FlorianMickler commented May 15, 2021

Hey, this is a trivial thing that has bitten at least two people in the past. Anyone up to merging this or redoing this? Should be a no-brainer.
This wasted so much time on my side that it would be really helpful for others to have this simple message in. I actually dug into the source code to find out why it was not working, because i was getting zero clue!

Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slipped through the gaps I suspect.

@paulidale paulidale added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels May 16, 2021
@paulidale paulidale self-assigned this May 16, 2021
@t8m t8m added the cla: trivial One of the commits is marked as 'CLA: trivial' label May 17, 2021
@t8m
Copy link
Member

t8m commented May 17, 2021

I am sorry but unfortunately this is outside of what we usually consider as acceptable under CLA: trivial. Could you please submit a CLA? https://www.openssl.org/policies/cla.html

@t8m t8m closed this May 17, 2021
@t8m t8m reopened this May 17, 2021
@FlorianMickler
Copy link
Contributor Author

I just submitted my ICLA. Do I need to ammend the commit description?

@paulidale
Copy link
Contributor

You'll need to remove the CLA: trivial line from each commit.

@paulidale paulidale closed this May 19, 2021
@paulidale paulidale reopened this May 19, 2021
@paulidale paulidale removed the cla: trivial One of the commits is marked as 'CLA: trivial' label May 19, 2021
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants