Add EVP_PKEY_get_default_digest_name() #10824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation pending |
levitte
force-pushed
the
add-EVP_PKEY_get_default_digest_name
branch
2 times, most recently
from
114cd47
to
c3c38a0
Compare
levitte
changed the title
|
Now that #10778 is merged, this has been rebased and taken out of WIP |
t8m
reviewed
Jan 17, 2020
| @@ -31,6 +31,7 @@ static int do_sigver_init(EVP_MD_CTX *ctx, EVP_PKEY_CTX **pctx, | |||
| { | |||
| EVP_PKEY_CTX *locpctx = NULL; | |||
| EVP_SIGNATURE *signature = NULL; | |||
| char locmdname[80] = ""; /* 80 chars should be enough */ | |||
There was a problem hiding this comment.
Could we have (perhaps internal) #define somewhere for this? Also below in the actual function implementation there is 100. Why this difference?
There was a problem hiding this comment.
I didn't remember between them...
A macro would be suitable. How about an internal OSSL_MAX_NAMESIZE?
There was a problem hiding this comment.
We have those in a number of places, so I'll make a sweep and submit that in another PR.
There was a problem hiding this comment.
See #10928. If that one gets a quick approval and merge, it'll be easy to rebase this one on top of that, and adapt accordingly.
levitte
force-pushed
the
add-EVP_PKEY_get_default_digest_name
branch
from
78bba61
to
8abf7bd
Compare
mattcaswell
requested changes
Jan 21, 2020
It is the provider version of EVP_PKEY_get_default_digest_nid(). We make sure to use it in the non-legacy section of do_sigver_init() (internal implementation for EVP_DigestSignInit() and EVP_DigestVerifyInit())
levitte
force-pushed
the
add-EVP_PKEY_get_default_digest_name
branch
from
8abf7bd
to
042281c
Compare
mattcaswell
approved these changes
Jan 22, 2020
mattcaswell
added
the
approval: done
openssl-machine
pushed a commit
that referenced
this pull request
Jan 23, 2020
It is the provider version of EVP_PKEY_get_default_digest_nid(). We make sure to use it in the non-legacy section of do_sigver_init() (internal implementation for EVP_DigestSignInit() and EVP_DigestVerifyInit()) Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10824)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 23, 2020
…mgmt Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to sign with provider side keys. Yet another fix of issues found by #10797
Please read the commit messages.