EC: deprecate the low level ECDH, ECDSA and EC_KEY_METHOD functions. #10960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure if I've been too aggressive about this or not aggressive enough. |
mattcaswell
requested changes
Jan 28, 2020
paulidale
force-pushed
the
dep-ec
branch
2 times, most recently
from
2317a8d
to
7de157d
Compare
levitte
reviewed
Jan 29, 2020
levitte
reviewed
Jan 29, 2020
levitte
reviewed
Jan 29, 2020
levitte
reviewed
Jan 29, 2020
levitte
reviewed
Jan 29, 2020
mattcaswell
requested changes
Jan 29, 2020
paulidale
force-pushed
the
dep-ec
branch
2 times, most recently
from
9fc6cef
to
72e553c
Compare
|
Rebased to remove merge conflict. |
mattcaswell
reviewed
Jan 31, 2020
Use of the low level ECDH functions has been informally discouraged for a long time. We now formally deprecate them.
Use of the low level ECDSA and EC_KEY_METHOD functions has been informally discouraged for a long time. We now formally deprecate them.
|
Rebased to remove the conflicts. |
mattcaswell
approved these changes
Feb 3, 2020
mattcaswell
added
approval: done
paulidale
removed
the
approval: done
paulidale
added
approval: ready to merge
|
Merged to master. Thanks for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 4, 2020
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10960)
openssl-machine
pushed a commit
that referenced
this pull request
Feb 4, 2020
Use of the low level ECDH functions has been informally discouraged for a long time. We now formally deprecate them. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10960)
openssl-machine
pushed a commit
that referenced
this pull request
Feb 4, 2020
Use of the low level ECDSA and EC_KEY_METHOD functions has been informally discouraged for a long time. We now formally deprecate them. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10960)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the low level EC functions.