Fix build with no-nextprotoneg #1100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
dirkfeytons
added a commit
to dirkfeytons/source
that referenced
this pull request
Jun 9, 2016
NPN has been superseded by ALPN so NPN is disabled by default The patch has been sent to OpenSSL for inclusion, see openssl/openssl#1100 Signed-off-by: Dirk Feytons <dirk.feytons@gmail.com>
dirkfeytons
added a commit
to dirkfeytons/source
that referenced
this pull request
Jun 9, 2016
NPN has been superseded by ALPN so NPN is disabled by default The patch has been sent to OpenSSL for inclusion, see openssl/openssl#1100 Signed-off-by: Dirk Feytons <dirk.feytons@gmail.com>
jow-
pushed a commit
to lede-project/source
that referenced
this pull request
Jul 23, 2016
NPN has been superseded by ALPN so NPN is disabled by default The patch has been sent to OpenSSL for inclusion, see openssl/openssl#1100 Signed-off-by: Dirk Feytons <dirk.feytons@gmail.com>
chunkeey
pushed a commit
to chunkeey/apm82181-lede
that referenced
this pull request
Jul 25, 2016
NPN has been superseded by ALPN so NPN is disabled by default The patch has been sent to OpenSSL for inclusion, see openssl/openssl#1100 Signed-off-by: Dirk Feytons <dirk.feytons@gmail.com>
|
Ping any team member. Looks straight forward. |
|
@dirkfeytons please can you provide us with a CLA so we can use your patch? Details here: |
|
+1 |
richsalz
added
the
approval: done
mattcaswell
added
the
hold: cla required
|
@mattcaswell: I've just emailed the CLA to the address mentioned in the document. |
|
got it, removed the hold label. can be merged. |
richsalz
removed
the
hold: cla required
dirkfeytons
force-pushed
the
fix_no-nextprotoneg
branch
from
a207928
to
5771ebf
Compare
Add a missing ifdef. Same change is already present in master.
dirkfeytons
force-pushed
the
fix_no-nextprotoneg
branch
from
5771ebf
to
8a51765
Compare
|
@mattcaswell @richsalz I've just rebased on current OpenSSL_1_0_2-stable and fixed the email address in the commit. Sorry it took so long... |
levitte
pushed a commit
that referenced
this pull request
Sep 22, 2016
Add a missing ifdef. Same change is already present in master. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1100)
|
commit f15a7e3. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing ifdef. Same change is already present in master.
Would be nice if 1.0.2 can also be built with no-nextprotoneg.