Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs typo fixes #11104

Closed
wants to merge 6 commits into from
Closed

Docs typo fixes #11104

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2020

This PR solves some typos detected in the following documentation files:

  • internal/man3/ossl_cmp_asn1_octet_string_set1.pod
  • internal/man3/ossl_param_bld_init.pod
  • man1/openssl-enc.pod.in
  • man1/openssl.pod
  • man5/config.pod
  • man5/x509v3_config.pod

levitte
levitte requested changes Feb 16, 2020
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise fine

doc/internal/man3/ossl_param_bld_init.pod Outdated Show resolved Hide resolved
romen
romen approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@romen romen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for this contribution!

@paulidale paulidale added approval: done This pull request has the required number of approvals branch: master Merge to master branch labels Feb 16, 2020
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 18, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Feb 18, 2020
@levitte
DOC:Fix typos in ossl_param_bld_init
af61cbc 
CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #11104)
openssl-machine pushed a commit that referenced this pull request Feb 18, 2020
@levitte
DOC:Fix typos in ossl_cmp_print_log.pod
7354f78 
CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #11104)
openssl-machine pushed a commit that referenced this pull request Feb 18, 2020
@levitte
DOC:Fix typos in openssl-enc.pod.in + openssl.pod
e02b13a 
CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #11104)
openssl-machine pushed a commit that referenced this pull request Feb 18, 2020
@levitte
DOC:Fix typos in man5/config.pod
0587a3a 
CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #11104)
openssl-machine pushed a commit that referenced this pull request Feb 18, 2020
@levitte
DOC:Fix typos in x509v3_config.pod
21542a4 
CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #11104)
@levitte
Copy link
Member

levitte commented Feb 18, 2020

A little bit of squashing, then merged

af61cbc DOC:Fix typos in ossl_param_bld_init
7354f78 DOC:Fix typos in ossl_cmp_print_log.pod
e02b13a DOC:Fix typos in openssl-enc.pod.in + openssl.pod
0587a3a DOC:Fix typos in man5/config.pod
21542a4 DOC:Fix typos in x509v3_config.pod

@levitte levitte closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openssl-machine @levitte @romen @paulidale