GH1123: sort dir before rehash

[richsalz]

This is needed to generate stable output names/symlinks.

[richsalz]

Replaces #1123

[sebastianas]

Thanks. scandir(, , , alphasort) would do the same job but then looking at the wrapper your have I am not sure if this makes it any simpler.

I tried to figure out where OPENSSL_DIR_read() is comming from but I failed. However I still think that you need OPENSSL_DIR_end(&d); and sk_OPENSSL_STRING_pop_free(files, str_free); in line 300:

+        if ((copy = strdup(filename)) == NULL
+              || sk_OPENSSL_STRING_push(files, copy) == 0) {
+            BIO_puts(bio_err, "out of memory\n");

☝️

+           return 1;
+        }

and looking up we would leak the buf memory or we don't care because it is an application that terminates soon anyway?

[richsalz]

Thanks. I changed them to call exit. No point in proceeding when malloc fails.

[richsalz]

pushed at b1ffe8d