Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Visual C warning about non-standard function names. #1129

Closed
wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented May 25, 2016

Visual C version from version 2003 complain about certain function
names, for example:

apps\apps.c(2572) : warning C4996: 'open': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _open. See online help for details.

This adds preprocessor aliases for them in e_os.h.

Additionally, crypto/conf/conf_lib.c needs to include e_os.h to catch
those aliases.

RT#4488
RT#4489

Visual C version from version 2003 complain about certain function
names, for example:

    apps\apps.c(2572) : warning C4996: 'open': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _open. See online help for details.

This adds preprocessor aliases for them in e_os.h.

Additionally, crypto/conf/conf_lib.c needs to include e_os.h to catch
those aliases.

RT#4488
RT#4489
@mattcaswell
Copy link
Member

+1

@mattcaswell mattcaswell added this to the 1.1.0 milestone May 25, 2016
@richsalz
Copy link
Contributor

This is bogus, since we're not compiling with C++. Stupid compiler. But I won't stand in the way.

@levitte
Copy link
Member Author

levitte commented May 25, 2016

Well yeah, but it's still giving off those stupid pesky warnings...

@levitte
Copy link
Member Author

levitte commented May 25, 2016

Merged

@levitte levitte closed this May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants