Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and a bit of cleanup in EC code #11452

Closed
wants to merge 2 commits into from
Closed

Fix bugs and a bit of cleanup in EC code #11452

wants to merge 2 commits into from

Conversation

dev-aaront-org
Copy link
Contributor

These changes fix several issues introduced with the FIPS changes in a9612d6.

@dev-aaront-org
Fix bugs in EC code introduced with FIPS changes.
6a836d8 
a9612d6 introduced possible memory leaks in EC_GROUP_cmp and EC_POINTs_mul, and a possible BN_CTX_end without BN_CTX_start in ec_field_inverse_mod_ord.
@dev-aaront-org
Remove an unnecessary call to BN_CTX_free.
7ad1079
mattcaswell
mattcaswell approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattcaswell mattcaswell added the approval: review pending This pull request needs review by a committer label Apr 1, 2020
@mattcaswell
Copy link
Member

Needs second review

t8m
t8m approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@t8m t8m added approval: done This pull request has the required number of approvals branch: master Merge to master branch and removed approval: review pending This pull request needs review by a committer labels Apr 1, 2020
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 2, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Apr 3, 2020
@dev-aaront-org @t8m
Fix bugs in EC code introduced with FIPS changes.
0e8b6c9 
a9612d6 introduced possible memory leaks in EC_GROUP_cmp and EC_POINTs_mul, and a possible BN_CTX_end without BN_CTX_start in ec_field_inverse_mod_ord.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #11452)
openssl-machine pushed a commit that referenced this pull request Apr 3, 2020
@dev-aaront-org @t8m
Remove an unnecessary call to BN_CTX_free.
94468c7 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #11452)
@t8m
Copy link
Member

t8m commented Apr 3, 2020

Merged to master as 94468c7 and 0e8b6c9
Thank you!

@t8m t8m closed this Apr 3, 2020
@dev-aaront-org dev-aaront-org deleted the ec-fips-bugs branch April 3, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dev-aaront-org @mattcaswell @openssl-machine @t8m