Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL::OID: Don't use List::Util #11503

Closed
wants to merge 1 commit into from
Closed

OpenSSL::OID: Don't use List::Util #11503

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Apr 9, 2020

It turns out that the pairwise functions of List::Util came into perl
far later than 5.10.0. We can't use that under those conditions, so
must revert to a quick internal implementation of the functions we're
after.

@levitte
OpenSSL::OID: Don't use List::Util
33519d1 
It turns out that the pairwise functions of List::Util came into perl
far later than 5.10.0.  We can't use that under those conditions, so
must revert to a quick internal implementation of the functions we're
after.
@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Apr 9, 2020
@levitte levitte requested a review from t8m April 9, 2020 10:12
@levitte levitte mentioned this pull request Apr 9, 2020
Closed
t8m
t8m approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the previously broken build passes. Also I think this is urgent.

@t8m t8m added approval: done This pull request has the required number of approvals severity: urgent Fixes an urgent issue (exempt from 24h grace period) and removed approval: review pending This pull request needs review by a committer labels Apr 9, 2020
@levitte
Copy link
Member Author

levitte commented Apr 9, 2020

Also I think this is urgent.

Agreed.

@levitte levitte added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 9, 2020
openssl-machine pushed a commit that referenced this pull request Apr 9, 2020
@levitte
OpenSSL::OID: Don't use List::Util
8519b24 
It turns out that the pairwise functions of List::Util came into perl
far later than 5.10.0.  We can't use that under those conditions, so
must revert to a quick internal implementation of the functions we're
after.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #11503)
@levitte
Copy link
Member Author

levitte commented Apr 9, 2020

Merged

8519b24 OpenSSL::OID: Don't use List::Util

@levitte levitte closed this Apr 9, 2020
@levitte levitte mentioned this pull request Apr 9, 2020
Closed
@levitte levitte deleted the fix-OID.pm branch June 6, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@levitte @t8m