EVP: Fix calls to evp_pkey_export_to_provider() #11550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
added
branch: master
slontis
reviewed
Apr 15, 2020
|
Please suggest a spot for such a test... or do you expect a whole new test program? (I was toying with the idea of making a library to collect test cases like this, and a program |
evp_extra_test? |
Ah! That's the pile of random tests! Thanks :-) |
|
Test added |
|
The new test fails :) |
I was tired when I wrote that :-/ Fixed, I hope |
2 tasks
paulidale
added
approval: done
levitte
commented
Apr 16, 2020
The calls weren't quite right, as this function has changed its behaviour. We also change the internal documentation of this function, and document evp_pkey_downgrade(). Fixes openssl#11549
…est.c We do it with RSA, which may seem strange. However, an RSA "template" is generally ignored, so this is safe. This is modelled after the test code given in github issue openssl#11549.
levitte
removed
the
approval: done
levitte
added
the
approval: review pending
slontis
approved these changes
Apr 16, 2020
levitte
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Pauli you wanna merge this? I am off for dinner.. |
|
Yep, merging. |
|
Merged. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 17, 2020
The calls weren't quite right, as this function has changed its behaviour. We also change the internal documentation of this function, and document evp_pkey_downgrade(). Fixes #11549 Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #11550)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 17, 2020
…est.c We do it with RSA, which may seem strange. However, an RSA "template" is generally ignored, so this is safe. This is modelled after the test code given in github issue #11549. Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #11550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calls weren't quite right, as this function has changed its behaviour.
We also change the internal documentation of this function, and document
evp_pkey_downgrade().
Fixes #11549