TEST: make and use a fipsinstall script #11565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have copies of the exact same fipsinstall call in several test recipes. This refactors those calls into a single simple script.
levitte
added
branch: master
paulidale
approved these changes
Apr 18, 2020
paulidale
added
approval: done
|
Assuming the CIs agree. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
levitte
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Apr 19, 2020
We have copies of the exact same fipsinstall call in several test recipes. This refactors those calls into a single simple script. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #11565)
|
Merged ae6b654 TEST: make and use a fipsinstall script |
|
@levitte The Travis breakage on OS/X was relevant. |
|
I'm trying to investigate that. |
richsalz
reviewed
Apr 21, 2020
| use platform; | ||
|
|
||
| my @providers = ($bldtop_dir, 'providers'); | ||
| my $fips_cnf = File::Spec->catfile(@providers, 'fipsinstall.cnf'); |
There was a problem hiding this comment.
Sigh. This is a a really bad name for the config file. It is about configuration of the FIPS module. I will update my "rename things" PR. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have copies of the exact same fipsinstall call in several test
recipes. This refactors those calls into a single simple script.