Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509/v3_alt.c: make 'othername' a bit bigger #11656

Closed
wants to merge 1 commit into from
Closed

crypto/x509/v3_alt.c: make 'othername' a bit bigger #11656

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Apr 27, 2020

We want to fill 'othername' with the contents of 'oline' (256 bytes)
plus some additional text. We need to ensure that 'othername' is
large enough to contain this.

@levitte
crypto/x509/v3_alt.c: make 'othername' a bit bigger
af94d3c 
We want to fill 'othername' with the contents of 'oline' (256 bytes)
plus some additional text.  We need to ensure that 'othername' is
large enough to contain this.
@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Apr 27, 2020
@levitte levitte added this to the 3.0.0 milestone Apr 27, 2020
paulidale
paulidale approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tempted to classify this coverity issue as a false positive. The copies to the buffer are well guarded.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 27, 2020
@levitte
Copy link
Member Author

levitte commented Apr 27, 2020

I had a compiler warning telling me that the contents of oline may be truncated...

@levitte levitte mentioned this pull request Apr 27, 2020
Closed
1 task
@mattcaswell
Copy link
Member

I'm marking this as "urgent". I'm getting build errors because of this problem.

@mattcaswell mattcaswell added the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Apr 27, 2020
openssl-machine pushed a commit that referenced this pull request Apr 27, 2020
@levitte
crypto/x509/v3_alt.c: make 'othername' a bit bigger
d0bcad7 
We want to fill 'othername' with the contents of 'oline' (256 bytes)
plus some additional text.  We need to ensure that 'othername' is
large enough to contain this.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #11656)
@levitte
Copy link
Member Author

levitte commented Apr 27, 2020

Merged

d0bcad7 crypto/x509/v3_alt.c: make 'othername' a bit bigger

@levitte levitte closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@levitte @mattcaswell @paulidale