Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s_server normal shutdown #11734

Closed
wants to merge 1 commit into from
Closed

s_server normal shutdown #11734

wants to merge 1 commit into from

Conversation

beldmit
Copy link
Member

@beldmit beldmit commented May 5, 2020

Partially fixes #11209

s_server application did not perform shutdown normally.

Checklist
  • documentation is added or updated
  • tests are added or updated

@beldmit beldmit added approval: otc review pending This pull request needs review by an OTC member branch: master Merge to master branch labels May 5, 2020
mattcaswell
mattcaswell requested changes May 5, 2020
View reviewed changes
apps/s_server.c Outdated Show resolved Hide resolved
apps/s_server.c Outdated Show resolved Hide resolved
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels May 5, 2020
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 6, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request May 6, 2020
@beldmit
s_server normal shutdown
edbb56e 
Partially fixes #11209

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #11734)
@beldmit
Copy link
Member Author

beldmit commented May 6, 2020

Merged. Thanks!

@beldmit beldmit closed this May 6, 2020
@beldmit beldmit deleted the fix_11209 branch May 6, 2020 14:55
@beldmit beldmit mentioned this pull request May 13, 2020
Closed
2 tasks
@mattcaswell mattcaswell mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EOF handling in s_client faliure
3 participants
@beldmit @openssl-machine @mattcaswell