Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast to at least 32 bit unsigned type when shifting left 24 places #11857

Closed
wants to merge 4 commits into from
Closed

Cast to at least 32 bit unsigned type when shifting left 24 places #11857

wants to merge 4 commits into from

Commits on May 19, 2020

  1. Cast the unsigned char to unsigned int before shifting left 

    This is needed to avoid automatic promotion to signed int.

Fixes openssl#11853

[extended tests]
    @t8m
    t8m committed May 19, 2020
    Copy the full SHA
    32cf890 View commit details
    Browse the repository at this point in the history

  2. Avoid potential overflow to the sign bit when shifting left 24 places 

    Although there are platforms where int is 64 bit, 2GiB large BIGNUMs
instead of 4GiB should be "big enough for everybody".
    @t8m
    t8m committed May 19, 2020
    Copy the full SHA
    a7be9c2 View commit details
    Browse the repository at this point in the history

  3. t1_trce: Fix remaining places where the 24 bit shift overflow happens 

    [extended tests]
    @t8m
    t8m committed May 19, 2020
    Copy the full SHA
    0b32df1 View commit details
    Browse the repository at this point in the history

  4. fixup! t1_trce: Fix remaining places where the 24 bit shift overflow … 

    …happens
    @t8m
    t8m committed May 19, 2020
    Copy the full SHA
    85b7559 View commit details
    Browse the repository at this point in the history