There is no -signreq option in CA.pl #11876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA: trivial
t8m
approved these changes
May 19, 2020
|
Unfortunately for 1.1.1 there should be a separate PR because the -signreq is mentioned at one additional place there. |
t8m
added
approval: review pending
mattcaswell
added
the
cla: trivial
mattcaswell
approved these changes
May 20, 2020
mattcaswell
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
May 21, 2020
CLA: trivial Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #11876)
|
Merged to master, would you like to create a PR for the 1.1.1 branch? |
|
@t8m is it normal to close a branch with un-merged commits? |
|
It is actually merged, the e1c6f76 is your commit, rebased and with the commit message adjusted so it contains the reviewed-by and link to the PR. |
yes, because the master source for openssl is not on github, but on an openssl server which the pushes to github as a read-only copy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA: trivial
Checklist