Misc apps fixes [2020-05-28] #11983
Misc apps fixes [2020-05-28] #11983
Conversation
levitte
added
branch: master
|
Explicitly running in the "C" locale seems like it will be bad for some users, e.g., @beldmit and @InfoHunter and their countrymen. Are you sure that's the right thing to do, rather than add a NOTE (sic) in the documentation? |
|
Explicit setting locale to "C" is often a way to find out an understandable (or at least googlable) diagnostic output in Russia :) |
|
In my case, not running under the "C" locale was bad. We are, after all, trying to match ASCII characters, so the "C" locale is the best way to ensure |
levitte
force-pushed
the
fix-apps-20200528
branch
from
b8b1659
to
c1875dd
Compare
|
I've dropped the locale change in apps/progs.pl, couldn't reproduce what went wrong when I tried again. |
t8m
added
the
approval: ready to merge
|
Approved 5 days ago by Bernd already. |
|
Merged e306f83 APPS: Remove make_config_name, use CONF_get1_default_config_file instead |
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #11983)
make_config_name()is a duplicate ofCONF_get1_default_config_file(), so drop it.apps/progs.plhas strange results when it's running in a national locale. For example,wisn't matched by the regular expression[a-z]in the Swedish locale (which meanspasswd_mainisn't matched, for example). To avoid that sort of surprise, we set the "C" locale.