kdf: make function naming consistent. #11996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is getting a timeout. |
|
I disagree with this change, on the same grounds as in #11997 (see #11997 (comment) for an explanation) |
|
Bought the naming in line with #11997 using the command: sed -i -e 's/EVP_KDF_CTX_new/EVP_KDF_new_ctx/g’ \
-e 's/EVP_KDF_CTX_free/EVP_KDF_free_ctx/g’ \
-e 's/EVP_KDF_CTX_dup/EVP_KDF_dup_ctx/g’ \
-e 's/EVP_KDF_CTX_kdf/EVP_KDF_get_ctx_kdf/g’ \
-e 's/EVP_KDF_CTX_get_params/EVP_KDF_get_ctx_params/g’ \
-e 's/EVP_KDF_CTX_set_params/EVP_KDF_set_ctx_params/g' \
`egrep -rl 'EVP_KDF_CTX_new|EVP_KDF_CTX_free|EVP_KDF_CTX_dup|EVP_KDF_CTX_kdf|EVP_KDF_CTX_get_params|EVP_KDF_CTX_set_params'` |
The EVP_KDF_CTX_* functions have been relocated to the EVP_KDF_* namespace for consistency.
levitte
approved these changes
Jun 9, 2020
levitte
added
the
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master. Thanks. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 11, 2020
The EVP_KDF_CTX_* functions have been relocated to the EVP_KDF_* namespace for consistency. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #11996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EVP_KDF_CTX functions have been renamed to bring consistency to the KDF naming.
Before 3.0 is released, the names are mutable and this prevents more inconsistencies being introduced.
There are no functional or code changes. Just the renaming and a little reformatting.