rand: Coverity fixes #12309
Closed
rand: Coverity fixes #12309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead appease coverity by marking 1464986 as a false positive. Coverity is confused by the engine reference counting.
paulidale
added
branch: master
|
Ping for review please. |
DDvO
reviewed
Jul 1, 2020
|
Looks ok to me.. Would approve if I could :) |
As @mattcaswell taught me: |
|
@slontis and I work for the same employer, we don't approve each other's PRs. Doing so would risk merging happening. |
t-j-h
approved these changes
Jul 3, 2020
paulidale
added
approval: done
t-j-h
approved these changes
Jul 3, 2020
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged to master, thanks for the feedback. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 5, 2020
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 5, 2020
Instead appease coverity by marking 1464986 as a false positive. Coverity is confused by the engine reference counting. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 5, 2020
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 5, 2020
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 5, 2020
…s it. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #12309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixing problems with the provider friendly rand work.
Also includes a fix for a null pointer dereference in properties and the removal of an unnecessary NULL check in apps/cmp.c