Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong fipsinstall key used in test #12402

Closed
wants to merge 1 commit into from
Closed

Fix wrong fipsinstall key used in test #12402

wants to merge 1 commit into from

Conversation

slontis
Copy link
Member

@slontis slontis commented Jul 9, 2020

This produces an error in the tests on master currently.

A newly merged test (in an old PR) was using the old fips install key.
Changed the test to use default values instead.

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis slontis added branch: master Merge to master branch approval: review pending This pull request needs review by a committer severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Jul 9, 2020
@slontis slontis added this to In progress in 3.0 New Core + FIPS via automation Jul 9, 2020
mattcaswell
mattcaswell approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is urgent

3.0 New Core + FIPS automation moved this from In progress to Reviewer approved Jul 9, 2020
@slontis
Copy link
Member Author

slontis commented Jul 9, 2020

It is after 11pm here, I am probably not going to be awake by the time travis gets around to running.

@mattcaswell
Copy link
Member

It is after 11pm here, I am probably not going to be awake by the time travis gets around to running.

I'll merge it

@t-j-h
Copy link
Member

t-j-h commented Jul 9, 2020

I agree this is urgent

@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 9, 2020
@mattcaswell
Copy link
Member

Travis errors are not relevant.

openssl-machine pushed a commit that referenced this pull request Jul 9, 2020
@slontis @mattcaswell
Fix wrong fipsinstall key used in test
2957150 
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #12402)
@mattcaswell
Copy link
Member

Pushed.

@mattcaswell mattcaswell closed this Jul 9, 2020
3.0 New Core + FIPS automation moved this from Reviewer approved to Done Jul 9, 2020
@mattcaswell mattcaswell mentioned this pull request Jul 9, 2020
Closed
@slontis
Copy link
Member Author

slontis commented Jul 9, 2020

Thanks matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)
Projects
No open projects
3.0 New Core + FIPS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slontis @mattcaswell @t-j-h