Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed swapped parameter descriptions for x509 #12482

Closed
wants to merge 1 commit into from
Closed

fixed swapped parameter descriptions for x509 #12482

wants to merge 1 commit into from

Conversation

noocsharp
Copy link
Contributor

Fixes #12382

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jul 19, 2020
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Jul 19, 2020
@slontis slontis added approval: otc review pending This pull request needs review by an OTC member branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch labels Jul 19, 2020
@slontis slontis added approval: review pending This pull request needs review by a committer and removed approval: otc review pending This pull request needs review by an OTC member labels Jul 19, 2020
beldmit
beldmit approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 20, 2020
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 21, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jul 21, 2020
@noocsharp @beldmit
fixed swapped parameter descriptions for x509
7e4f01d 
CLA: trivial

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #12482)
@beldmit
Copy link
Member

beldmit commented Jul 21, 2020

Merged to master. Many thanks!

Unfortunately, the fix does not apply cleanly to 1_1_1-stable.
@noocsharp, could you please make a separate PR for 1_1_1-stable?

@beldmit beldmit closed this Jul 21, 2020
@beldmit beldmit removed the branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch label Jul 21, 2020
@noocsharp noocsharp mentioned this pull request Jul 21, 2020
Closed
@t8m t8m added the cla: trivial One of the commits is marked as 'CLA: trivial' label Jul 21, 2020
@t8m
Copy link
Member

t8m commented Jul 21, 2020

This was marked CLA: trivial in the commit. And I agree it is.

@beldmit beldmit mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beldmit beldmit beldmit approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explanations of subject_hash_old and issuer_hash_old are reversed.
5 participants
@noocsharp @openssl-machine @beldmit @t8m @slontis