Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: extra return value checking #12678

Closed
wants to merge 2 commits into from
Closed

Conversation

paulidale
Copy link
Contributor

Some functions aren't checking their return values when they can fail. Add two such checks.

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Aug 19, 2020
@paulidale paulidale added this to the 3.0.0 milestone Aug 19, 2020
@paulidale paulidale self-assigned this Aug 19, 2020
@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 19, 2020
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 20, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Aug 20, 2020
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #12678)
openssl-machine pushed a commit that referenced this pull request Aug 20, 2020
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #12678)
@paulidale
Copy link
Contributor Author

Merged to master, thanks.

@paulidale paulidale closed this Aug 20, 2020
@paulidale paulidale deleted the fixes branch August 20, 2020 08:31
swenkeratmicrosoft pushed a commit to swenkeratmicrosoft/openssl that referenced this pull request Sep 1, 2020
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#12678)
swenkeratmicrosoft pushed a commit to swenkeratmicrosoft/openssl that referenced this pull request Sep 1, 2020
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#12678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants