Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in FIPS_MODULE endif macro comment #12755

Closed
wants to merge 1 commit into from
Closed

Fix typo in FIPS_MODULE endif macro comment #12755

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Aug 31, 2020

No description provided.

@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Aug 31, 2020
@levitte
Copy link
Member

levitte commented Aug 31, 2020

The Duke of Mo had only a short time with us...

@DDvO
Copy link
Contributor

DDvO commented Aug 31, 2020

The Duke of Mo had only a short time with us...

Yet we're giving him a grace period such that people have a chance to intervene or to say goodbye 😉

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@slontis slontis added approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch and removed approval: done This pull request has the required number of approvals labels Sep 3, 2020
openssl-machine pushed a commit that referenced this pull request Sep 3, 2020
@danbev @slontis
Fix typo in FIPS_MODULE endif macro comment
6f04bcc 
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #12755)
@slontis
Copy link
Member

slontis commented Sep 3, 2020

Thanks. Merged to master.
Farewell Duke, may we meet again in better circumstances.

@slontis slontis closed this Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDvO DDvO DDvO approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@danbev @levitte @DDvO @openssl-machine @slontis @mattcaswell @paulidale