Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid uninitialised variable warning when running tests with 'TESTS=xxx' #12762

Closed
wants to merge 1 commit into from
Closed

Avoid uninitialised variable warning when running tests with 'TESTS=xxx' #12762

wants to merge 1 commit into from

Conversation

jon-oracle
Copy link
Contributor

When running tests locally using 'TESTS=xxx' I get a warning for every run:

$ make TESTS=test_genrsa test
make depend && make _tests
make[1]: Entering directory '/home/jon/work/jaffa/openssl/openssl-aix-fix'
make[1]: Leaving directory '/home/jon/work/jaffa/openssl/openssl-aix-fix'
make[1]: Entering directory '/home/jon/work/jaffa/openssl/openssl-aix-fix'
( SRCTOP=. \
  BLDTOP=. \
  PERL="/usr/bin/perl" \
  FIPSKEY="f4556650ac31d35461610bac4ed81b1a181b2d8a43ea2854cbae22ca74560813" \
  EXE_EXT= \
  /usr/bin/perl ./test/run_tests.pl test_genrsa )
Use of uninitialized value $ENV{"HARNESS_JOBS"} in numeric gt (>) at ./test/run_tests.pl line 60.
15-test_genrsa.t .. ok    
All tests successful.
Files=1, Tests=14,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.85 cusr  0.14 csys =  1.02 CPU)
Result: PASS
make[1]: Leaving directory '/home/jon/work/jaffa/openssl/openssl-aix-fix'

This seems to be related to the recent PR:

#12326

paulidale
paulidale approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Not that I'd even noticed.

beldmit
beldmit approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals branch: master Merge to master branch labels Sep 1, 2020
mattcaswell
mattcaswell approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Not that I'd even noticed.

I noticed. I was hoping someone else was going to come up with a fix :-)

@levitte
Copy link
Member

levitte commented Sep 1, 2020

I noticed. I was hoping someone else was going to come up with a fix :-)

Heh, me too. It's time others get their hands perly 😉

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@beldmit
Copy link
Member

beldmit commented Sep 2, 2020

Merged. Thanks!

@beldmit beldmit closed this Sep 2, 2020
openssl-machine pushed a commit that referenced this pull request Sep 2, 2020
@jon-oracle @beldmit
Avoid uninitialised variable warning for jobs
ef0f01c 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #12762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jon-oracle @levitte @openssl-machine @beldmit @mattcaswell @paulidale