Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate potential -Wunused-function violations in err.h #12851

Closed
wants to merge 1 commit into from
Closed

Annotate potential -Wunused-function violations in err.h #12851

wants to merge 1 commit into from

Conversation

jwalch
Copy link
Contributor

@jwalch jwalch commented Sep 10, 2020

Fixes #12792

Supersedes #12796 & #12843

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Sep 10, 2020
paulidale
paulidale approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing that these are trivial changes if that CLA path is taken.

@paulidale paulidale added the branch: master Merge to master branch label Sep 10, 2020
@jwalch
Copy link
Contributor Author

jwalch commented Sep 15, 2020

Kicking CLA bot

@jwalch jwalch closed this Sep 15, 2020
@jwalch jwalch reopened this Sep 15, 2020
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Sep 15, 2020
@jwalch jwalch closed this Sep 15, 2020
@jwalch jwalch reopened this Sep 15, 2020
@levitte levitte added the approval: done This pull request has the required number of approvals label Sep 15, 2020
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Sep 16, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Sep 16, 2020
@kroeckx kroeckx added this to the 3.0.0 beta1 milestone Sep 16, 2020
@paulidale
Copy link
Contributor

Merged to master, thanks for the contribution.

@paulidale paulidale closed this Sep 17, 2020
openssl-machine pushed a commit that referenced this pull request Sep 17, 2020
@jwalch @paulidale
Annotate potential -Wunused-function violations in err.h
067a305 
Fixes #12792

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #12851)
@jwalch jwalch deleted the unused-func branch September 17, 2020 20:46
@paulnelsontx paulnelsontx added this to Ready to merge in 3.0.0 estimator Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
No open projects
3.0.0 estimator
Ready to merge
Milestone
3.0.0 beta1
Development

Successfully merging this pull request may close these issues.

Potentially unused static functions in err.h starting in 3.0.0
5 participants
@jwalch @openssl-machine @paulidale @levitte @kroeckx