Code Constification #1300
Code Constification #1300
Conversation
| typedef ASN1_VALUE *ASN1_new_func(void); | ||
| typedef void ASN1_free_func(ASN1_VALUE *a); | ||
| typedef ASN1_VALUE *ASN1_d2i_func(ASN1_VALUE **a, const unsigned char **in, | ||
| long length); | ||
| typedef int ASN1_i2d_func(ASN1_VALUE *a, unsigned char **in); | ||
|
|
||
| */ |
There was a problem hiding this comment.
yes, please back this change out from this MR.
There was a problem hiding this comment.
Yes, it is out-of-topic., my mistake.
FdaSilvaYY
force-pushed
the
ossl_constification
branch
7 times, most recently
from
022f9c5
to
96dff3e
Compare
FdaSilvaYY
force-pushed
the
ossl_constification
branch
5 times, most recently
from
0bc16c3
to
8f572ba
Compare
|
+1; needs a second review. |
simplify and reindent some related code.
…YPE_get_octetstring & co...
simplify and reindent some related code. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
…YPE_get_octetstring & co... Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
- X509_NAME_entry_count, X509_ATTRIBUTE_count - X509_NAME_add_entry_by_OBJ, X509_NAME_ENTRY_create_by_OBJ, X509_NAME_ENTRY_set_object Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
X509_REVOKED_get0_extensions X509_check_private_key Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1300)
|
(looks like some trailing whitespace snuck in in a couple of these commits, but "meh") |
|
Yup. Meh. Senior Architect, Akamai Technologies From: kaduk [mailto:notifications@github.com] (looks like some trailing whitespace snuck in in a couple of these commits, but "meh") — |
I try to be conservative ;)
Feel free to comment