Constify OSSL_FUNC_keymgmt_validate() #13201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keydata argument of OSSL_FUNC_keymgmt_validate() should be read-only.
2 tasks
slontis
approved these changes
Oct 21, 2020
slontis
added
the
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged with d1fb6b4 Thanks! |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 23, 2020
The keydata argument of OSSL_FUNC_keymgmt_validate() should be read-only. Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #13201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keydata argument of
OSSL_FUNC_keymgmt_validate()should be read-only.Followup from #13200 , but this is more involved because with
DHkeys we lie a bit and we need to cast and discard the qualifier when grabbing the inner Montgomery context.Operating on the Montgomery context should not alter the contents of the
DHkey, so I believe it is appropriate to lie here and cast away theconstfor that struct field.Checklist