Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ecdsa digest setting code to match dsa. #13520

Closed
wants to merge 3 commits into from
Closed

Fix ecdsa digest setting code to match dsa. #13520

wants to merge 3 commits into from
+139 −78

Commits on Nov 26, 2020

  1. Fix ecdsa digest setting code to match dsa. 

    Fixes openssl#13422

ecdsa_set_ctx_params() was not setting the digest correctly. The side
effect noted was that the check for sha1 when signing was not being
done in fips mode.

Also fixed the dupctx() so that propq is deep copied.
The usage of the variable 'flag_allow_md' was also copied from the dsa code.
    @slontis
    slontis committed Nov 26, 2020
    Copy the full SHA
    eb849de View commit details
    Browse the repository at this point in the history

  2. Fix dsa & rsa signature dupctx() so that ctx->propq is strduped 

    Discovered when fixing up ecdsa code.
    @slontis
    slontis committed Nov 26, 2020
    Copy the full SHA
    8c5b972 View commit details
    Browse the repository at this point in the history

  3. fixup! Fix ecdsa digest setting code to match dsa.

    @slontis
    slontis committed Nov 26, 2020
    Copy the full SHA
    069528a View commit details
    Browse the repository at this point in the history