apps/pkcs12.c: Improve user guidance, re-ordering no-export vs. export options #13588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDvO
added
the
approval: otc review pending
t8m
reviewed
Dec 1, 2020
t8m
reviewed
Dec 1, 2020
t8m
reviewed
Dec 1, 2020
t8m
reviewed
Dec 1, 2020
|
Thanks @t8m for you comments. I've followed all your suggestions. |
t8m
approved these changes
Dec 2, 2020
t8m
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
…t options Make the option order consistent in the help output and in the POD file. Give warnings when an option is ignored because -export is given or missing. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from openssl#13588)
DDvO
force-pushed
the
rearrange_pkc12_options
branch
from
2af5cea
to
902161e
Compare
|
Rebased, fixed merge conflict, and merged - thanks @t8m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the option order consistent in the help output and in the POD file.
Give warnings when an option is ignored because
-exportis given or missing.