Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-tls1_3 #13596

Closed
wants to merge 4 commits into from
Closed

Fix no-tls1_3 #13596

wants to merge 4 commits into from

Conversation

mattcaswell
Copy link
Member

Also fixes no-tls1_2

If we're using TLSv1.2 then the test_sigalgs_available test needs to be
careful which ciphersuite is selected in order for the test to behave
correctly.
@mattcaswell mattcaswell added the branch: master Merge to master branch label Dec 2, 2020
@mattcaswell mattcaswell added this to the 3.0.0 beta1 milestone Dec 2, 2020
@mattcaswell
Copy link
Member Author

Fixup pushed to address a CI failure.

test/sslapitest.c Outdated Show resolved Hide resolved
@mattcaswell
Copy link
Member Author

Fixup pushed addressing feedback. Please take another look.

@t8m t8m added the approval: done This pull request has the required number of approvals label Dec 2, 2020
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 3, 2020
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Dec 8, 2020
If we're using TLSv1.2 then the test_sigalgs_available test needs to be
careful which ciphersuite is selected in order for the test to behave
correctly.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #13596)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2020
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #13596)
@mattcaswell
Copy link
Member Author

Pushed. Thanks.

@mattcaswell mattcaswell closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants