Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract out policy and extensions in CA.pl #13819

Closed
wants to merge 1 commit into from
Closed

Abstract out policy and extensions in CA.pl #13819

wants to merge 1 commit into from

Conversation

gtbX
Copy link
Contributor

@gtbX gtbX commented Jan 8, 2021

This lets you customize extensions and policy used in CA.pl in one place rather than scattered around.

CLA: trivial

Checklist

@mattcaswell
Copy link
Member

I'm ok with this, but I think it goes beyond "CLA: trivial" by our definition (which generally is used for very small changes/typos etc). Please can you complete a CLA:

https://www.openssl.org/policies/cla.html

@t8m t8m added cla: trivial One of the commits is marked as 'CLA: trivial' hold: cla required The contributor needs to submit a license agreement labels Feb 18, 2021
@openssl-machine
Copy link
Collaborator

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided. For CLA help see https://www.openssl.org/policies/cla.html

@openssl-machine
Copy link
Collaborator

This PR has the label 'hold: cla required' and is stale: it has not been updated in 61 days. Note that this PR may be automatically closed in the future if no CLA is provided. For CLA help see https://www.openssl.org/policies/cla.html

@gtbX
Copy link
Contributor Author

gtbX commented Apr 21, 2021

ICLA submitted

@openssl-machine
Copy link
Collaborator

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided. For CLA help see https://www.openssl.org/policies/cla.html

@openssl-machine
Copy link
Collaborator

This PR has the label 'hold: cla required' and is stale: it has not been updated in 61 days. Note that this PR may be automatically closed in the future if no CLA is provided. For CLA help see https://www.openssl.org/policies/cla.html

@openssl-machine
Copy link
Collaborator

This PR has the label 'hold: cla required' and is stale: it has not been updated in 92 days. Note that this PR may be automatically closed in the future if no CLA is provided. For CLA help see https://www.openssl.org/policies/cla.html

@gtbX
Copy link
Contributor Author

gtbX commented Jul 31, 2021

I submitted an ICLA corresponding to the email address I used to create the commit. Not sure what else needs to happen.

@t8m t8m closed this Aug 2, 2021
@t8m t8m reopened this Aug 2, 2021
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Aug 2, 2021
@t8m t8m added the hold: cla required The contributor needs to submit a license agreement label Aug 2, 2021
@t8m
Copy link
Member

t8m commented Aug 2, 2021

Please use git commit --amend and then force push to remove the CLA: trivial line from the commit.

kaduk
kaduk approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@kaduk kaduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t8m did you expect the close/reopen to clear the "CLA needed" flag? (It doesn't seem to have done so.)

@t8m
Copy link
Member

t8m commented Aug 3, 2021

@t8m did you expect the close/reopen to clear the "CLA needed" flag? (It doesn't seem to have done so.)

Yes, but I did not realize that the commit has CLA: trivial which is incorrect. So I re-added the label and asked for amending the commit message.

@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Aug 4, 2021
@paulidale paulidale added approval: done This pull request has the required number of approvals branch: master Merge to master branch and removed cla: trivial One of the commits is marked as 'CLA: trivial' labels Aug 4, 2021
@paulidale paulidale added this to the Post 3.0.0 milestone Aug 4, 2021
@paulidale paulidale added the triaged: feature The issue/pr requests/adds a feature label Aug 4, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Aug 5, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Aug 5, 2021
@t8m t8m added the hold: merge after release This pull request must not be merged until after the release from the merge branch is done label Aug 5, 2021
@t8m t8m added triaged: refactor The issue/pr requests/implements refactoring and removed triaged: feature The issue/pr requests/adds a feature hold: merge after release This pull request must not be merged until after the release from the merge branch is done labels Nov 11, 2021
@mattcaswell
Copy link
Member

Pushed to master. Thanks.

openssl-machine pushed a commit that referenced this pull request Nov 16, 2021
@gtbX @mattcaswell
Abstract out policy and extensions in CA.pl
3066cf2 
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #13819)
ramikhaldi pushed a commit to ramikhaldi/openssl that referenced this pull request Nov 21, 2021
@gtbX @rkhaldi
Abstract out policy and extensions in CA.pl
3de10ca 
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#13819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaduk kaduk kaduk approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: refactor The issue/pr requests/implements refactoring
Projects
None yet
Milestone
Post 3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gtbX @mattcaswell @openssl-machine @t8m @kaduk @paulidale