Rm err get string table #1389
Closed
Rm err get string table #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #1379 |
| hash = get_hash(0, 0); | ||
| if (hash) | ||
| p = lh_ERR_STRING_DATA_retrieve(hash, d); | ||
| if (int_error_hash) |
|
I'm happy to see this in preference to 1379, modulo style nits. |
|
yeah, fixed those with an updated commit. thanks. |
| @@ -1800,7 +1800,6 @@ EVP_PKEY_meth_get_verify_recover 1785 1_1_0 EXIST::FUNCTION: | |||
| NAME_CONSTRAINTS_check 1786 1_1_0 EXIST::FUNCTION: | |||
| X509_CERT_AUX_it 1787 1_1_0 EXIST:!EXPORT_VAR_AS_FUNCTION:VARIABLE: | |||
| X509_CERT_AUX_it 1787 1_1_0 EXIST:EXPORT_VAR_AS_FUNCTION:FUNCTION: | |||
| ERR_get_string_table 1788 1_1_0 EXIST::FUNCTION: | |||
There was a problem hiding this comment.
This introduces a "gap" in libcrypto.num. Do we need to recreate this before final release? Not a problem for this MR though I think.
|
+1 for merge after beta |
mattcaswell
added
the
approval: done
levitte
pushed a commit
that referenced
this pull request
Aug 4, 2016
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #1389)
levitte
pushed a commit
that referenced
this pull request
Aug 4, 2016
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #1389)
|
merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.