Deprecate EVP_MD_CTX_{set_}update_fn() #14008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slontis
reviewed
Jan 29, 2021
|
Could you please add CHANGES.md entry? |
|
Added CHANGES.md, updated the commit, rebased, pushed. |
t8m
reviewed
Feb 1, 2021
CHANGES.md
Outdated
| @@ -29,6 +29,11 @@ OpenSSL 3.0 | |||
|
|
|||
| *Tomas Mraz* | |||
|
|
|||
| * Deprecate EVP_MD_CTX_set_update_fn() and EVP_MD_CTX_update_fn() | |||
| although they are still used internally in legacy (engine) code. | |||
There was a problem hiding this comment.
I am not sure the although they are still used internally in legacy (engine) code. is really bringing any important information to the user. I think something like as they are not useful with non-deprecated functionality. would be better. Or something in that sense.
There was a problem hiding this comment.
I thought what I had gave more info, but I don't care very much. Wording changed and updated commit pushed.
They are still used internally in legacy code. Also fixed up some minor things in EVP_DigestInit.pod Fixes: #14003
t8m
approved these changes
Feb 1, 2021
t8m
added
the
approval: review pending
paulidale
added
approval: done
levitte
approved these changes
Feb 2, 2021
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged to master. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are still used internally in legacy code.
Also fixed up some minor things in EVP_DigestInit.pod
Fixes: #14003