Improves CTLOG_STORE setters #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes them to have clearer ownership semantics, as suggested in openssl#1372 (comment).
|
+1 |
RJPercival
force-pushed
the
ctlog_store_setters
branch
from
0666625
to
cf314fa
Compare
| { | ||
| ctx->cert = cert; | ||
| if (X509_up_ref(cert)) |
There was a problem hiding this comment.
If they can fail then they should no longer be void.
They may fail if they cannot increment the reference count of the certificate they are storing a pointer for. They should return 0 if this occurs.
|
still +1 needs another reviewer. |
| @@ -291,7 +291,7 @@ CRYPTO_gcm128_setiv 291 1_1_0 EXIST::FUNCTION: | |||
| ASN1_PCTX_set_oid_flags 292 1_1_0 EXIST::FUNCTION: | |||
| d2i_ASN1_INTEGER 293 1_1_0 EXIST::FUNCTION: | |||
| i2d_PKCS7_ENCRYPT 294 1_1_0 EXIST::FUNCTION: | |||
| CT_POLICY_EVAL_CTX_set0_issuer 295 1_1_0 EXIST::FUNCTION:CT | |||
| CT_POLICY_EVAL_CTX_set0_issuer 295 1_1_0 NOEXIST::FUNCTION: | |||
There was a problem hiding this comment.
you could delete these since they now never existed (not sure if we have a script to clean them up before the release)
There was a problem hiding this comment.
Should I leave a gap in the number sequence or replace them with the new set1 functions?
There was a problem hiding this comment.
Put the new functions directly in place of the old ones. Then I’ll merge.
|
+1 |
|
merged, thanks. closing. |
levitte
pushed a commit
that referenced
this pull request
Aug 15, 2016
Changes them to have clearer ownership semantics, as suggested in #1372 (comment). Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1408)
levitte
pushed a commit
that referenced
this pull request
Aug 15, 2016
They may fail if they cannot increment the reference count of the certificate they are storing a pointer for. They should return 0 if this occurs. Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1408)
levitte
pushed a commit
that referenced
this pull request
Aug 15, 2016
…o.num Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1408)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes them to have clearer ownership semantics, as suggested in
#1372 (comment).