Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/s_server + s_client: Replace 'SSL_CTX_new' by 'SSL_CTX_new_ex' #14195

Closed
wants to merge 1 commit into from
Closed

apps/s_server + s_client: Replace 'SSL_CTX_new' by 'SSL_CTX_new_ex' #14195

wants to merge 1 commit into from

Conversation

gotthardp
Copy link
Contributor

The openssl s_server and openssl s_client currently ignore the -propquery parameter. Fix patch fixes this.

@gotthardp
Replace SSL_CTX_new by SSL_CTX_new_ex in apps/s_server + s_client
251b0b2 
The `openssl s_server` and `openssl s_client` currently ignore
the `-propquery` parameter. Fix patch fixes this.
slontis
slontis approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI loop failure is not related to this PR.

@slontis slontis added approval: done This pull request has the required number of approvals branch: master Merge to master branch labels Feb 16, 2021
@mattcaswell mattcaswell mentioned this pull request Feb 15, 2021
Open
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 17, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Feb 17, 2021
@gotthardp @slontis
Replace SSL_CTX_new by SSL_CTX_new_ex in apps/s_server + s_client
574ca40 
The `openssl s_server` and `openssl s_client` currently ignore
the `-propquery` parameter. Fix patch fixes this.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #14195)
@slontis
Copy link
Member

slontis commented Feb 17, 2021

Thanks for fixing this. Merged to master.

@slontis slontis closed this Feb 17, 2021
@gotthardp gotthardp deleted the fix_apps_server_propq branch February 25, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gotthardp @openssl-machine @slontis @mattcaswell @paulidale