GH1446: Add SSL_SESSION_get0_cipher #1451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| =head1 HISTORY | ||
|
|
||
| SSL_SESSION_get_protocol_version() was first added to OpenSSL 1.1.0 |
There was a problem hiding this comment.
Minor detail: I guess this history section should refer to the new method?
There was a problem hiding this comment.
Yes, thanks, fixed. Updated commit pushed.
|
|
||
| #include <openssl/ssl.h> | ||
|
|
||
| const SSL_CIPHER *SSL_SESSION_get0_cipher(const SSL_SESSSION *s); |
There was a problem hiding this comment.
Typo in the parameter type.
There was a problem hiding this comment.
fixed, tnx. will merge.
|
+1 assuming you fix the typo. |
mattcaswell
added
the
approval: done
levitte
pushed a commit
that referenced
this pull request
Aug 13, 2016
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #1451)
|
commit e928132 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1446