Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in bio.pod #14706

Closed
wants to merge 1 commit into from
Closed

Fix typos in bio.pod #14706

wants to merge 1 commit into from

Conversation

NanXiao
Copy link
Contributor

@NanXiao NanXiao commented Mar 27, 2021

CLA: trivial

Checklist
  • documentation is added or updated

@NanXiao
Fix typos in bio.pod
1f5dea9 
CLA: trivial
@kroeckx kroeckx added approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' labels Mar 27, 2021
slontis
slontis approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that it is trivial

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 27, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Mar 29, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Mar 29, 2021
openssl-machine pushed a commit that referenced this pull request Mar 30, 2021
@NanXiao @t8m
Fix typos in bio.pod
1ee1a16 
CLA: trivial

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #14706)
@t8m
Copy link
Member

t8m commented Mar 30, 2021

Merged to master. Thank you for the contribution.

@t8m t8m closed this Mar 30, 2021
@NanXiao NanXiao deleted the nan-bio-pod branch March 30, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroeckx kroeckx kroeckx approved these changes

@t8m t8m t8m approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge cla: trivial One of the commits is marked as 'CLA: trivial'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NanXiao @openssl-machine @t8m @kroeckx @slontis