Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in statem_clnt.c #14791

Closed
wants to merge 1 commit into from
Closed

Fix typo in statem_clnt.c #14791

wants to merge 1 commit into from

Conversation

NanXiao
Copy link
Contributor

@NanXiao NanXiao commented Apr 7, 2021

CLA: trivial

Checklist
  • documentation is added or updated

@paulidale
Copy link
Contributor

Agreed, trivial.

mattcaswell
mattcaswell approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree trivial.

@paulidale paulidale added approval: done This pull request has the required number of approvals branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' labels Apr 7, 2021
@paulidale paulidale self-assigned this Apr 7, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 8, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged to master, thanks for the fix.

@paulidale paulidale closed this Apr 9, 2021
openssl-machine pushed a commit that referenced this pull request Apr 9, 2021
@NanXiao @paulidale
Fix typo in statem_clnt.c
3201abe 
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #14791)
@NanXiao NanXiao deleted the nan-typo-statem_clnt branch April 9, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NanXiao @paulidale @openssl-machine @mattcaswell