KMAC buffer overflow fix #14810
Closed
KMAC buffer overflow fix #14810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
added
branch: master
slontis
reviewed
Apr 9, 2021
slontis
reviewed
Apr 9, 2021
slontis
reviewed
Apr 9, 2021
FdaSilvaYY
reviewed
Apr 9, 2021
|
I've also run through and converted the sizes to size_t. |
Previously there was an off by two error allowing a stack buffer overrun. Avoided this by allocating a correct sized buffer on the stack. A side effect is that the maximum size of the customisation string can be increased.
|
Should be all happy for a re-review now. |
slontis
reviewed
Apr 11, 2021
|
Added an overly long customisation string test case (257 characters). |
slontis
added
approval: done
|
Pauli can you try to remember to add the #fixes to the description at the top please... ( I added it here and in another recent PR). |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 12, 2021
Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #14810)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 12, 2021
Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #14810)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 12, 2021
Previously there was an off by two error allowing a stack buffer overrun. Avoided this by allocating a correct sized buffer on the stack. A side effect is that the maximum size of the customisation string can be increased. Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #14810)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 12, 2021
Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #14810)
|
Merged to master, I'll try to remember to include the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a buffer overflow (two byte on the stack).
Also increases the length of the customisation string.
Fixes #14795