-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps/cms: Simplify handling of encerts; add warning if they are ignored #14843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDvO
added
the
approval: otc review pending
This pull request needs review by an OTC member
label
Apr 12, 2021
AppVeyor failure is unrelated. |
Rebased to fix merge conflict. |
t8m
requested changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor fix needed.
DDvO
force-pushed
the
cms_app_encerts
branch
2 times, most recently
from
May 18, 2021 20:32
c0f274a
to
370bac9
Compare
@t8m, is this okay now? |
t8m
approved these changes
May 21, 2021
t8m
added
approval: done
This pull request has the required number of approvals
branch: master
Merge to master branch
and removed
approval: otc review pending
This pull request needs review by an OTC member
labels
May 21, 2021
openssl-machine
added
approval: ready to merge
The 24 hour grace period has passed, ready to merge
and removed
approval: done
This pull request has the required number of approvals
labels
May 22, 2021
This pull request is ready to merge |
Merged - thanks @t8m |
openssl-machine
pushed a commit
that referenced
this pull request
May 22, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #14843)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#14843)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approval: ready to merge
The 24 hour grace period has passed, ready to merge
branch: master
Merge to master branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA