Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/cms: Simplify handling of encerts; add warning if they are ignored #14843

Closed
wants to merge 1 commit into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Apr 12, 2021

SSIA

@DDvO DDvO added the approval: otc review pending This pull request needs review by an OTC member label Apr 12, 2021
@DDvO
Copy link
Contributor Author

DDvO commented Apr 14, 2021

AppVeyor failure is unrelated.

@DDvO
Copy link
Contributor Author

DDvO commented May 14, 2021

Rebased to fix merge conflict.
Can we please get this done?

Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix needed.

apps/cms.c Show resolved Hide resolved
@DDvO DDvO force-pushed the cms_app_encerts branch 2 times, most recently from c0f274a to 370bac9 Compare May 18, 2021 20:32
@DDvO
Copy link
Contributor Author

DDvO commented May 20, 2021

@t8m, is this okay now?

@DDvO DDvO requested a review from t8m May 21, 2021 05:05
@t8m t8m added approval: done This pull request has the required number of approvals branch: master Merge to master branch and removed approval: otc review pending This pull request needs review by an OTC member labels May 21, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 22, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@DDvO
Copy link
Contributor Author

DDvO commented May 22, 2021

Merged - thanks @t8m

openssl-machine pushed a commit that referenced this pull request May 22, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #14843)
@DDvO DDvO closed this May 24, 2021
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#14843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants