RT4130: Add enginesdir to pkg-config file #1501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for master and 1.1.0 |
|
Hm, should we add it to libcrypto.pc too? Or instead? |
|
libcrypto.pc instead. |
|
@levitte better? |
|
Yup, I'm happy with that. |
levitte
added
the
approval: done
|
@richsalz, do you see a reason not to have this for 1.0.2 as well? |
|
(it will be a separate PR, of course) |
|
Meanwhile, I've merged this into master and 1.1.0 |
|
If you think it's a bugfix, +1 from me for 1.0.2 |
dwmw2
pushed a commit
to dwmw2/libp11
that referenced
this pull request
Sep 12, 2016
Which it should from OpenSSL 1.1 onwards, and distributions which mess around with the engine directory could also add it for earlier versions. cf. openssl/openssl#1501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make the openssl.pc pkg-config file tell where the engines directory is.
Currently, engines which need to install into the correct directory need to jump through hoops and apply various distribution-specific knowledge to try to find it.
See https://github.com/OpenSC/libp11/blob/master/configure.ac#L100 and weep.