Add testing for updated cipher IV #15041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
added
approval: review pending
|
What about adding a "Fixes #14047" line in the commit? |
t8m
added
approval: done
|
Nice job! |
t8m
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Apr 28, 2021
Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #15041)
|
Merged to master. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #14047 some updated IVs have been generated using an alternate crypto toolkit (RSA BSAFE) where the supported ciphers/modes overlap.
The evp_test app now supports using the 'NextIV' tag in the test data to provide an expected value to compare against.