Add padding spaces before printing signature algorithm. #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any new progress on this PR? |
richsalz
approved these changes
Nov 14, 2017
richsalz
added
branch: master
levitte
added
approval: review pending
paulidale
approved these changes
Nov 14, 2017
paulidale
added
approval: done
|
@hotpxl do you agree this is a trivial change? |
|
Is there a formal definition of trivial change? If not, then yes. This only affects human-readable text output. It doesn't involve any security related features. |
|
Sorry I wasn't clear. Something small, simple, and/or obvious that is therefore not copyrightable code. |
|
Yes, definitely. |
|
ping @paulidale to confirm triviality :) |
levitte
pushed a commit
that referenced
this pull request
Nov 15, 2017
CLA: trivial Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Rich Salz <tjh@openssl.org> (Merged from #1513)
|
Thanks. Merged to master. (And thanks for the nudge, this had been forgotten, sorry.) |
levitte
pushed a commit
to levitte/openssl
that referenced
this pull request
Nov 16, 2017
CLA: trivial Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Rich Salz <tjh@openssl.org> (Merged from openssl#1513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing x509 certificates like
It has two
Signature Algorithmlines. InCHANGES:7466it introduces a functionX509_signature_printto deduplicate the print routine. But it would result in one of the lines having incorrect indentation.This PR manually added the indentation back.